fix: nacos service discovery request lacks retries after failure #12734
+151
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
nic-6443
reviewed
Nov 24, 2025
| else | ||
| local ok, err = fetch_from_host(base_uri, username, password, infos) | ||
| if ok then | ||
| return |
Member
There was a problem hiding this comment.
I think we can remember index of healthy one in a variable in this lua module, so that we can chose the healthy one nacos host directly in next sync.
Contributor
Author
There was a problem hiding this comment.
My idea is that the states of health and unhealth are unreliable without health checks, as they can change at any time. Therefore, I don't see the need to store these states.
The current implementation is only a minor improvement; adding health checks will completely eliminate this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After confirmation, the problem described in the original issue also exists in nacos service discovery. Currently, if multiple nacos nodes are configured, a request will randomly select one; if that node fails, the request can only be made again during the next synchronization.
This PR optimizes this behavior so that when a request from one node fails, it will resend the request to other nodes.
Which issue(s) this PR fixes:
Fixes #12610
Checklist